[webkit-dev] C++ unit tests for WebKit?

[Konrad Piascik]

Don't we have gunit tests in Tools/TestWebKitAPI already?
________________________________________
From: webkit-dev-bounces at lists.webkit.org [webkit-dev-bounces at lists.webkit.org] on behalf of Hans Muller [hmuller at adobe.com]
Sent: Wednesday, July 11, 2012 5:23 PM
To: webkit-dev
Subject: [webkit-dev] C++ unit tests for WebKit?

Bear Travis, Alexandru Chiculita, and I have been working on the WebKit CSS Exclusions implementation.   I've been working on a set of C++ classes that are used to compute the layout of inline content around or within exclusion shapes.  When I got started, before attempting to integrate the code with WebKit, I wrote a pile of unit tests.  This was helpful for the usual reasons but there doesn't appear to be a place for low level unit tests in WebKit.  Naturally what I've done will be tested in terms of the Exclusions public JavaScript and CSS APIs, so adding lower level unit tests will not drastically change our confidence about the overall feature working correctly.  On the other hand, unit tests can be useful for isolating problems and for implicitly specifying interface semantics that wouldn't otherwise be documented.

Have the merits of C++ unit tests been debated before?  I noticed that a bug representing as much has been around since 2008 (https://bugs.webkit.org/show_bug.cgi?id=21010).  The last comment (2009) concludes with: "I'd be interested to hear other's thoughts."   Personally, I'd like to be able to include unit tests with worthy C++ classes, however I would also like to hear other's thoughts.


Thanks,
- Hans


---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.