[webkit-dev] JavaScriptCore AST generator bug?

Laurent Desegur laurent at gameclosure.com
Sun Jul 8 10:59:39 PDT 2012


While experimenting with the new llint in JSCore,  I noticed that the
Not class (located in offlineasm/ast.rb) may have an incorrect method:

class Not < Node
    attr_reader :child

    def initialize(codeOrigin, child)
        super(codeOrigin)
        @child = child
    end

    def children
        [@left, @right]
    end

    def mapChildren
        Not.new(codeOrigin, (yield @child))
    end

    def dump
        "(not #{child.dump})"
    end
end



Shouldn't children of this 'Not' class be

    def children
        [@child]
    end

instead, since it's  a unary operator?

Before filing a bug, I'd like to get the opinion of someone familiar
with the code base.

Thanks,

LdS


More information about the webkit-dev mailing list