[webkit-dev] Asking for review by pinging bugs---another approach
gyuyoung at gmail.com
Thu Jan 5 03:34:26 PST 2012
In new port case, for example EFL port, we unfortunately don't have special
reviewer for our port yet.
So, we have requested to review on IRC after finishing our informal review.
If we only
ask some reviewers to review, the reviewers will have too many review
burden. We have
found proper reviewers on IRC in order to avoid this. In this case, is
there better way to
find proper reviewer for EFL port patch ?
Happy new year !!
On Thu, Jan 5, 2012 at 5:03 PM, Andreas Kling <kling at webkit.org> wrote:
> On Thu, Jan 5, 2012 at 7:49 AM, Adam Barth <abarth at webkit.org> wrote:
>> Not to pick on anyone in particular, but when reading bugmail I
>> occasionally see messages like "pinging for review." I review a lot
>> of patches, but I don't find these messages particularly helpful
>> because I don't know whether I'm supposed to review the patch.
>> Another approach that might work better for you is to address your
>> comment at someone in particular. For example, if the message says
>> "Adam, can you please review this patch?", then there's a pretty good
>> chance I'll click through and try to answer your question.
>> If you're unsure who to ask for review, one approach is to look at the
>> svn log for the files you're changing and see who has written/reviewed
>> patches for those files recently. You can also ask folks who've been
>> around the project for a while to suggest someone.
> True that.
> You can also find reviewers for a particular area here on the WebKit Team
> wiki page: http://trac.webkit.org/wiki/WebKit%20Team (and I encourage
> people to keep their entry up-to-date.)
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev