[webkit-dev] Announcement of Coding Style Change in WebKit EFL port

Gyuyoung Kim gyuyoung at gmail.com
Sun Jan 1 17:43:56 PST 2012


Ok, I'm going to file a bug for style checker. And, add you guys to CC. :-)

Thank you,
Gyuyoung.

On Sat, Dec 31, 2011 at 7:09 AM, David Levin <levin at google.com> wrote:

> Feel free to patch the style checker as appropriate. I suspect there may
> be some changes needed here:
>
> http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checker.py#L180
>
> Best wishes,
> dave
>
> On Tue, Dec 27, 2011 at 11:54 PM, Gyuyoung Kim <gyuyoung.kim at samsung.com>wrote:
>
>>  Hello WebKit folks,
>>
>>
>> As you may know, I have changed the coding style of EFL port via Bug
>> 68209. This is to eliminate unnecessary difficulties
>>
>> that reviewers have experienced when they review EFL bugs, due to EFL
>> specific coding style.
>>
>>
>>
>> Bug 68209 - [EFL] Change WebKit EFL coding style
>>
>> (https://bugs.webkit.org/show_bug.cgi?id=68209)
>>
>>
>>
>> Major changes are as below,
>>
>>
>>
>> 1. Use full variable name instead of abbreviation name.
>>
>> 2. Use standard boolean type instead of EFL boolean type.
>>
>> 3. Place '*' operator immediately after the data type. (For example, use
>> char* userAgent. instead of char *userAgent.)
>>
>> 4. Use C++ type casting instead of C type casting.
>>
>> 5. Remove void parameter from internal functions.
>>
>> 6. Use camelCase instead of  underbar(_) in variable names.
>>
>>
>>
>> I made a wiki page for this rule.  I will update this page whenever EFL
>> port coding style guide is changed.
>>
>> (http://trac.webkit.org/wiki/EFLWebKitCodingStyle)
>>
>>
>>
>> To sum up, EFL port adheres to WebKit coding style except for public
>> header from now.
>>
>> (Because public header is used by EFL applications, public header will
>> continue to follow the coding style rule of EFL.)
>>
>>
>>
>> We hope that reviewing of EFL port patches will be much easier after this
>> change.
>>
>>
>>
>> Happy new year !!
>>
>>
>>
>> Regards,
>>
>> Gyuyoung Kim.
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120102/41d71f33/attachment.html>


More information about the webkit-dev mailing list