[webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

My current plan is to have a WTF/wtf directory to avoid this exact issue. :)

And to avoid the annoyance of 131 files in the root WTF directory.

I'm open to other suggestions if folks have them.

-eric

On Tue, Feb 28, 2012 at 3:59 PM, Mark Rowe <mrowe at apple.com> wrote:
>
> On 2012-02-28, at 07:38, Osztrogonac Csaba <oszi at inf.u-szeged.hu> wrote:
>
>> Hi,
>>
>> I uploaded the necessary buildfix for Qt to the bugzilla: https://bugs.webkit.org/show_bug.cgi?id=79783 .
>>
>> Please be careful with moving JavaScriptCore/wtf to WTF, because we
>> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>>
>> I made it locally to be able prepare the Qt buildfix and I had to replace all
>> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
>> The patch is huge, ~2Mb and ~4000 files are affected.
>>
>> I suggest landing the following patches separately:
>> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
>> - s/wtf/WTF/g patch :)
>
> I hadn't considered this issue of case before.  Having to replace all instances of #include <wtf/Foo.h> with #include <WTF/Foo.h> will make this much, much more likely to cause breakages than if we left the original case alone. It also seems somewhat tangential to the goal of moving WTF out of JavaScriptCore.
>
> - Mark
>
>> Eric Seidel írta:
>>> We've been talking about moving WTF out of JavaScriptCore for a long
>>> time.  We believe we're nearly there.
>>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>> This will mean that WTF will be built as a separate static library on all ports.
>>> The plan is to do this move all in one piece, after work hours PST,
>>> when the tree is least active.
>>> It won't be the most beautiful transition (as we're likely to break at
>>> least one port in the process), but we'll try not to make too much of
>>> a mess.
>>> We believe all the ports are ready for the move, except AppleWin:
>>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>> Once AppleWin is ready we'll schedule a date for the transition and
>>> announce it one this thread.
>>> Thanks!
>>> -eric
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev