[webkit-dev] The Care and Feeding of WebCore Modules
abarth at webkit.org
Tue Feb 28 10:50:10 PST 2012
Yeah. I haven't studied the Settings issue carefully yet. If you
look at patches that add a new setting, they need to add a ridiculous
amount of boilerplate code, especially if they want to test the
setting. Reducing this overhead seems valuable (whether by
autogeneration or other means), especially if that lowers the
activation energy for writing good tests.
On Tue, Feb 28, 2012 at 10:47 AM, Simon Fraser <simon.fraser at apple.com> wrote:
> "Let's auto generate it" doesn't logically follow from "it's getting large
> and unwieldy" to me.
> It seems that a better approach would be to figure out how to simplify
> Settings (do we still need them all?), and if we do, perhaps to break it up
> On Feb 28, 2012, at 10:27 AM, Darin Fisher wrote:
> Good idea!
> On Tue, Feb 28, 2012 at 8:46 AM, Adam Barth <abarth at webkit.org> wrote:
>> We haven't done anything about Settings yet, but Setting is also kind
>> of growing out of control. My initial read is that we should try to
>> autogenerate Settings (and maybe some/all of the Settings-related
>> boilerplate in the WebKit layer) from an "in" file.
>> On Tue, Feb 28, 2012 at 7:40 AM, Darin Fisher <darin at chromium.org> wrote:
>> > Nice. Is there a plan for modularizing Settings?
>> > On Feb 28, 2012 12:30 AM, "Adam Barth" <abarth at webkit.org> wrote:
>> >> I wrote up a short wiki page explaining how the modules system works
>> >> and how to use it when building new features:
>> >> https://trac.webkit.org/wiki/Modules
>> >> We've been making good progress refactoring some existing features to
>> >> use the system. This refactoring both improves the hackability of
>> >> WebCore by simplifying the core objects (e.g.,
>> >> Page/DOMWindow/Document/Navigator) and paves the cowpaths for new code
>> >> to avoid bloating these objects.
>> >> In Bug 79663, Alexey asked why we were moving the WebSocket
>> >> declaration out of WorkerContext.idl and into Modules/websockets.
>> >> Viewed in isolation, I can understand why that change looks somewhat
>> >> mysterious. Hopefully the wiki page above provides some more context
>> >> for the change. In particular, WebSockets fits neatly into the
>> >> modules pattern. We've already removed almost all mentions of
>> >> WebSockets from WebCore proper. Besides one item in
>> >> WebCore::Settings, WorkerContext.idl is the last file in WebCore
>> >> proper to mention WebSockets.
>> >> Adam
>> >> _______________________________________________
>> >> webkit-dev mailing list
>> >> webkit-dev at lists.webkit.org
>> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
More information about the webkit-dev