[webkit-dev] Subpixel Layout Update

Robert O'Callahan robert at ocallahan.org
Sun Feb 12 12:47:01 PST 2012


Cool!

FYI, your formula for enclosingIntRect is wrong. Consider, e.g., x=0.4 and
width=0.7.

Also, in pixelSnappedIntRect, you need to ensure that your rounding
function doesn't round towards (or away from) 0. See
http://robert.ocallahan.org/2008/02/rounding-towards-or-away-from-zero_12.html.
In particular libc round() does not do the right thing. (I didn't look at
your code so maybe you already discovered this :-).)

Rob
-- 
"If we claim to be without sin, we deceive ourselves and the truth is not
in us. If we confess our sins, he is faithful and just and will forgive us
our sins and purify us from all unrighteousness. If we claim we have not
sinned, we make him out to be a liar and his word is not in us." [1 John
1:8-10]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120213/aa6d984f/attachment.html>


More information about the webkit-dev mailing list