[webkit-dev] test_expectations.txt for non-chromium ports

Dirk Pranke dpranke at chromium.org
Fri Feb 10 16:20:33 PST 2012


I think at one point Adam indicated he wanted to use them for the
Apple Win port, but he is still using the Skipped files since the Win
port is still using ORWT on the bots.

That said, I understand why you're asking this (I think), but I would
prefer that we not have to support both options indefinitely into the
future. I would like to merge whatever features we need from both
approaches into one solution if possible (of course, we can do that
after forcing ports to use only one or the other for now).

The last time this was discussed at any length, people seemed to want
expectations to cascade, but I never got any clear feedback on what
the semantics of the cascade would be, and how that might interact
with different modifiers in the test_expectations file.

Since that time, I've come to believe that even the way Chromium uses
expectations files is just making things harder for developers and
maintainers, and so I would like to change how Chromium does things as
well ... this is a long-winded way of saying most things are on the
table for discussion.

For example, we might want to use only Skipped files for tests that
are always planned to be skipped, and test_expectations for things
that are supposed to be temporary workarounds to keep the tree green
until bugs can be filed and new baselines generated. Or, we might want
to do something else ...

-- Dirk

On Fri, Feb 10, 2012 at 1:07 PM, Ojan Vafai <ojan at chromium.org> wrote:
> Do any non-chromium ports want to use test_expectations.txt instead of or in
> addition to Skipped files? I think we should only allow one or the other per
> port. Having both for all ports keeps causing confusion.
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>


More information about the webkit-dev mailing list