[webkit-dev] What is the license policy of a reviewing patch on Bugzilla (not yet landed to main trunk)?

[Ryosuke Niwa]

In principle that should be the case. But I've seen cases where people
didn't realize some files they uploaded on Bugzilla weren't compatible with
LGPL or BSD until the review process so we should probably judge on
case-by-case basis in practice if the patch contains new files or code
imported from elsewhere.

In the case of people uploading a code change patch (as supposed to
importing new third-party tests, etc...), it's clear that they must have
agreed them to be licensed under LGPL or BSD, however.

Best,
Ryosuke Niwa
Software Engineer
Google Inc.

On Mon, Feb 6, 2012 at 5:20 PM, Adam Barth <abarth at webkit.org> wrote:

> IANAL, but here's what the bugs.webkit.org attachment page says:
>
> ======
> WebKit Contribution Terms:
>
> Hello and thank you for contributing a patch. Here is our licensing
> policy and terms for contributing code to the WebKit project.
>
> If you are sending in a patch to existing WebKit code, you agree by
> clicking below that your changes are licensed under the existing
> license terms of the file you are modifying (i.e., BSD license or GNU
> Lesser General Public License v.2.1, LGPL v. 2.1). Please also add
> your copyright (name and year) to the relevant files for changes that
> are more than 10 lines of code.
>
> If you are sending in a new file for inclusion in WebKit (no code
> copied from another source), the preferred license is BSD, but LGPL
> 2.1 is an option as well. Please include your copyright (name and
> year) and license preference (BSD or LGPL 2.1). By clicking below you
> agree that your file is licensed under either the BSD license or LGPL
> 2.1, as indicated in your file.
>
> If you aren't the author of the patch, you agree to include the
> original copyright notices and licensing terms with it, to the extent
> that they exist. If there wasn't a copyright notice or license, please
> make a note of it. Generally we can only take in patches that are BSD-
> or LGPL-licensed in order to maintain license compatibility within the
> project.
> ======
>
> That seems to imply that these licensing terms apply to any patches
> uploaded to bugs.webkit.org, not just those that are merged to trunk.
>
> Adam
>
>
> On Mon, Feb 6, 2012 at 5:10 PM, Gyuyoung Kim <gyuyoung.kim at samsung.com>
> wrote:
> > Hello WebKit folks,
> >
> > I am wondering what is the license policy for reviewing patches on
> bugzilla (not yet merged to main trunk).
> > As you know, contributor should agree legal terms related to
> license(LGPLv.2.1, BSD) before submitting to bugzilla.
> >
> > So do the legal terms apply to final patches that are merged to main
> trunk ONLY ?  Or do they also cover patches that
> > are still under review on bugzilla?
> >
> > Appreciate if someone could answer this question.
> >
> > -- Gyuyoung
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120206/26d95ddf/attachment.html>