[webkit-dev] CSSGroupingRule and a bit of refactoring?

Pablo Flouret pablof at motorola.com
Wed Dec 12 17:41:47 PST 2012


Hello webkit folk,

I'm working on having @supports behave like a proper CSSSupportsRule [1].

In the css3-conditional spec, CSSSupportsRule inherits from a
CSSGroupingRule (CSSMediaRule does as well):
http://dev.w3.org/csswg/css3-conditional/#the-cssgroupingrule-interface.

I'm wondering if it's a good idea, as a first step, to do a bit of
refactoring and rip the stuff that's now in CSSGroupingRule from
CSSMediaRule (cssRules/insertRule/deleteRule), and have the supports
and media rules inherit from it.

Incidentally, i see at least WebKitCSSKeyframesRule and
WebKitCSSRegionRule also having similar but not quite identical
re-implementations of these functions, but i guess whether these ones
should also inherit from CSSGroupingRule might be a question for the
standards mailing lists first (in any case, they would potentially
benefit from such a refactoring).

Opinions / advice / potential problems?

Thanks!

[1] http://wkbug.com/104822

-- 
pablo flouret
motorola | webkit / browser team


More information about the webkit-dev mailing list