[webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

Eric Seidel eric at webkit.org
Tue Dec 11 15:43:53 PST 2012


Nevermind.  After further discussion with Nico, this can't work yet.

Ninja is currently configured to use a non-webkitty "out" build
directory, which is undoubtably going to confus some scripts/bots.

We'll try this again at a later time.  Apologies for the noise.

http://trac.webkit.org/changeset/137375

On Tue, Dec 11, 2012 at 3:33 PM, Eric Seidel <eric at webkit.org> wrote:
> This is now complete:
> http://trac.webkit.org/changeset/137371
>
> I'm watching the bots.  Please contact me if you have any trouble.
>
> Thank you all for your feedback.
>
> On Mon, Dec 10, 2012 at 10:11 AM, Dirk Pranke <dpranke at chromium.org> wrote:
>> On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger <jochen at chromium.org> wrote:
>>> Will the buildbots use ninja or the "native" build tools?
>>>
>>> My only concern is that we're catching problems with e.g. MSVS only after we
>>> roll the WebKit deps in chromium and one of the MSVS bots starts failing.
>>>
>>
>> Eric is only suggesting changing update-webkit and build-webkit, which
>> means that only the webkit.org bots would be affected. As long as the
>> chromium.org canaries are still using chromium checkouts (and the
>> native build systems), we'll still have coverage.
>>
>> Of course, your point is still valid for other scenarios where we
>> don't have coverage of what we use on the official builds, but as Nico
>> pointed out in a separate thread, so far this hasn't been a frequent
>> problem.
>>
>> -- Dirk


More information about the webkit-dev mailing list