[webkit-dev] Please avoid rolling out patches speculatively and reland them ASAP if you had to

Ryosuke Niwa rniwa at webkit.org
Tue Dec 11 13:41:29 PST 2012

On Tue, Dec 11, 2012 at 12:17 PM, Emil A Eklund <eae at chromium.org> wrote:

> If the build is broken and the gardener/build cop has a strong reason
> to suspect that it was caused by a specific patch and the author is
> unavailable then rolling that patch out is the right thing to do.

Sure. If the author isn't available via IRC & emails within a reasonable
time, and the regression is as serious as a build failure, then rolling out
the patch is quite reasonable even if it's speculative.

On the other hand, if the patch being rolled out turned out be not the
cause of whatever failure the person rolled it out for, then it should be
his/her responsibility to re-land the patch.

It might inconvenience the author but it is the responsibility of the
> author and reviewer to make sure the patch didn't break anything.


- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121211/9ed9b095/attachment.html>

More information about the webkit-dev mailing list