[webkit-dev] Please avoid rolling out patches speculatively and reland them ASAP if you had to

Emil A Eklund eae at chromium.org
Tue Dec 11 13:11:17 PST 2012


On Tue, Dec 11, 2012 at 12:19 PM, Ojan Vafai <ojan at chromium.org> wrote:
> On Tue, Dec 11, 2012 at 12:17 PM, Emil A Eklund <eae at chromium.org> wrote:
>>
>> I'll have to disagree with you here.
>>
>> If the build is broken and the gardener/build cop has a strong reason
>> to suspect that it was caused by a specific patch and the author is
>> unavailable then rolling that patch out is the right thing to do. It
>
>
> "author is unavailable" is the key statement here.

Indeed.

> That said, if your strong reason turned out to be incorrect, you should recommit the patch, no?

That seems like a bad idea, someone that understands the patch should
recommit it. Ideally the original author.


More information about the webkit-dev mailing list