[webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

Nico Weber thakis at chromium.org
Mon Dec 10 08:40:48 PST 2012


On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger <jochen at chromium.org> wrote:
> Will the buildbots use ninja or the "native" build tools?
>
> My only concern is that we're catching problems with e.g. MSVS only after we
> roll the WebKit deps in chromium and one of the MSVS bots starts failing.

The idea is that gyp tries to write ninja files that behave as similar
as possible to xcodebuild / devenv (or msbuild). In practice, this
seems to work pretty well and it's rare that a ninja build works while
xcodebuild doesn't -- well enough that all the chromium trybots use
only ninja.

Nico

>
> Otherwise, I'm all for switching to ninja.
>
> best
> -jochen
>
> On Sat, Dec 8, 2012 at 9:29 AM, Eric Seidel <eric at webkit.org> wrote:
>>
>> If you don't work on the Chromium port, feel free to ignore.
>>
>>
>> If you work on the Chromium port of WebKit and do not use Ninja as you
>> build system (GYP_GENERATORS='ninja' or update-webkit --chromium
>> --ninja) I want to hear from you!
>>
>> As far as I can tell, the vast majority of Chromium contributors use
>> Ninja as their build system of choice.  Particularly for
>> Chromium-Android contributors this seems to be true.
>>
>> With that knowledge, I have posted a patch to make update-webkit
>> ---chromium/--chromium-android generate Ninja build files instead of
>> platform-native build files (XCode, Visual Studio, Make, etc.) by
>> default.  This of course only affects the chromium port.
>>
>> https://bugs.webkit.org/show_bug.cgi?id=104434
>>
>> Thanks!
>>
>>
>> p.s. If you don't already know:
>> update-webkit --chromium --ninja
>> build-webkit --chromium
>> is all you need to use Ninja today.  You don't even need to have
>> installed/built your own copy of ninja (Chromium has done that for
>> you).
>>
>> p.p.s. Ninja is awesome. Awesomely quiet. Awesomely fast.
>> http://martine.github.com/ninja/
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
>


More information about the webkit-dev mailing list