[webkit-dev] Unresolved external on ews-win even after the symbol added in WebKit2.def.in

[Brent Fulgham]

Hi Xianzhu,

I think you are correct.  I'll look at this now.  Thanks for the report.

-Brent


On Tue, Dec 4, 2012 at 8:55 PM, Xianzhu Wang <wangxianzhu at chromium.org>wrote:

> Hi,
>
> I just tested with a temporary patch that removed most of the contents of
> WebKit2.def.in (https://bugs.webkit.org/attachment.cgi?id=177603).
> ews-win still reported one unresolved external just as for the previous
> patches (http://queues.webkit.org/results/15153238). So I suspect that
> WebKit2.def was not updated from the changed WebKit2.def.in (I think
> otherwise there should be many other unresolved external errors). However I
> don't know much of Windows build and might be incorrect.
>
> @bfulgham, could you confirm?
>
> Thanks,
> Xianzhu
>
> On Tue, Dec 4, 2012 at 3:00 PM, Xianzhu Wang <wangxianzhu at chromium.org>wrote:
>
>> Hi,
>>
>> In https://bugs.webkit.org/attachment.cgi?id=177534, I added the symbol
>> into Source/WebKit2/WebKit2.def.in trying to resolve the "unresolved
>> external" error of the previous patch (
>> https://bugs.webkit.org/attachment.cgi?id=177506), but the error still
>> occurred. I have read https://trac.webkit.org/wiki/ExportingSymbols (the
>> WebKit2.def part should be updated). The only file I haven't changed is
>> WebKit2.order (which I guess doesn't matter). Should there be sth like
>> "generating ...\WebKit2ExportGenerator\WebKit2.def" in the log if
>> WebKit2.def.in is changed in the patch?
>>
>> Thanks,
>> Xianzhu
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121205/c14fac66/attachment.html>