No subject
Wed Aug 1 07:28:53 PDT 2012
One minor nit, but I'll reply with that on the bug. Thanks for doing this!
Peter
On Mon, Dec 10, 2012 at 9:39 AM, Eric Seidel <eric at webkit.org> wrote:
> The buildbots will use ninja by default, but could opt-out (with
> --no-ninja) if that were desired behavior.
>
>
> I've so far received one other concern:
> Robert Hogan raised that chromium's depot_tools does not contain a
> 32-bit build of ninja, and the error message is somewhat confusing in
> that case. I've filed https://bugs.webkit.org/show_bug.cgi?id=104523
> for tracking that issue.
>
> On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger <jochen at chromium.org>
> wrote:
> > Will the buildbots use ninja or the "native" build tools?
> >
> > My only concern is that we're catching problems with e.g. MSVS only
> after we
> > roll the WebKit deps in chromium and one of the MSVS bots starts failing.
> >
> > Otherwise, I'm all for switching to ninja.
> >
> > best
> > -jochen
> >
> > On Sat, Dec 8, 2012 at 9:29 AM, Eric Seidel <eric at webkit.org> wrote:
> >>
> >> If you don't work on the Chromium port, feel free to ignore.
> >>
> >>
> >> If you work on the Chromium port of WebKit and do not use Ninja as you
> >> build system (GYP_GENERATORS='ninja' or update-webkit --chromium
> >> --ninja) I want to hear from you!
> >>
> >> As far as I can tell, the vast majority of Chromium contributors use
> >> Ninja as their build system of choice. Particularly for
> >> Chromium-Android contributors this seems to be true.
> >>
> >> With that knowledge, I have posted a patch to make update-webkit
> >> ---chromium/--chromium-android generate Ninja build files instead of
> >> platform-native build files (XCode, Visual Studio, Make, etc.) by
> >> default. This of course only affects the chromium port.
> >>
> >> https://bugs.webkit.org/show_bug.cgi?id=104434
> >>
> >> Thanks!
> >>
> >>
> >> p.s. If you don't already know:
> >> update-webkit --chromium --ninja
> >> build-webkit --chromium
> >> is all you need to use Ninja today. You don't even need to have
> >> installed/built your own copy of ninja (Chromium has done that for
> >> you).
> >>
> >> p.p.s. Ninja is awesome. Awesomely quiet. Awesomely fast.
> >> http://martine.github.com/ninja/
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo/webkit-dev
> >
> >
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
--001517447ceed92b4804d07e6de4
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Clarifying the error messages seems like a win in either case.<div><br></di=
v><div>From Android's perspective, I'm of course in favor of switch=
ing to ninja. One minor nit, but I'll reply with that on the bug. Thank=
s for doing this!<br>
<div class=3D"gmail_extra"><br>Peter<br><br><div class=3D"gmail_quote">On M=
on, Dec 10, 2012 at 9:39 AM, Eric Seidel <span dir=3D"ltr"><<a href=3D"m=
ailto:eric at webkit.org" target=3D"_blank">eric at webkit.org</a>></span> wro=
te:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">The buildbots will use ninja by default, but=
could opt-out (with<br>
--no-ninja) if that were desired behavior.<br>
<br>
<br>
I've so far received one other concern:<br>
Robert Hogan raised that chromium's depot_tools does not contain a<br>
32-bit build of ninja, and the error message is somewhat confusing in<br>
that case. =A0I've filed <a href=3D"https://bugs.webkit.org/show_bug.cg=
i?id=3D104523" target=3D"_blank">https://bugs.webkit.org/show_bug.cgi?id=3D=
104523</a><br>
for tracking that issue.<br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger <<a href=3D"mailto:joch=
en at chromium.org">jochen at chromium.org</a>> wrote:<br>
> Will the buildbots use ninja or the "native" build tools?<br=
>
><br>
> My only concern is that we're catching problems with e.g. MSVS onl=
y after we<br>
> roll the WebKit deps in chromium and one of the MSVS bots starts faili=
ng.<br>
><br>
> Otherwise, I'm all for switching to ninja.<br>
><br>
> best<br>
> -jochen<br>
><br>
> On Sat, Dec 8, 2012 at 9:29 AM, Eric Seidel <<a href=3D"mailto:eric=
@webkit.org">eric at webkit.org</a>> wrote:<br>
>><br>
>> If you don't work on the Chromium port, feel free to ignore.<b=
r>
>><br>
>><br>
>> If you work on the Chromium port of WebKit and do not use Ninja as=
you<br>
>> build system (GYP_GENERATORS=3D'ninja' or update-webkit --=
chromium<br>
>> --ninja) I want to hear from you!<br>
>><br>
>> As far as I can tell, the vast majority of Chromium contributors u=
se<br>
>> Ninja as their build system of choice. =A0Particularly for<br>
>> Chromium-Android contributors this seems to be true.<br>
>><br>
>> With that knowledge, I have posted a patch to make update-webkit<b=
r>
>> ---chromium/--chromium-android generate Ninja build files instead =
of<br>
>> platform-native build files (XCode, Visual Studio, Make, etc.) by<=
br>
>> default. =A0This of course only affects the chromium port.<br>
>><br>
>> <a href=3D"https://bugs.webkit.org/show_bug.cgi?id=3D104434" targe=
t=3D"_blank">https://bugs.webkit.org/show_bug.cgi?id=3D104434</a><br>
>><br>
>> Thanks!<br>
>><br>
>><br>
>> p.s. If you don't already know:<br>
>> update-webkit --chromium --ninja<br>
>> build-webkit --chromium<br>
>> is all you need to use Ninja today. =A0You don't even need to =
have<br>
>> installed/built your own copy of ninja (Chromium has done that for=
<br>
>> you).<br>
>><br>
>> p.p.s. Ninja is awesome. Awesomely quiet. Awesomely fast.<br>
>> <a href=3D"http://martine.github.com/ninja/" target=3D"_blank">htt=
p://martine.github.com/ninja/</a><br>
>> _______________________________________________<br>
>> webkit-dev mailing list<br>
>> <a href=3D"mailto:webkit-dev at lists.webkit.org">webkit-dev at lists.we=
bkit.org</a><br>
>> <a href=3D"http://lists.webkit.org/mailman/listinfo/webkit-dev" ta=
rget=3D"_blank">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href=3D"mailto:webkit-dev at lists.webkit.org">webkit-dev at lists.webkit.org<=
/a><br>
<a href=3D"http://lists.webkit.org/mailman/listinfo/webkit-dev" target=3D"_=
blank">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</div></div></blockquote></div><br></div></div>
--001517447ceed92b4804d07e6de4--
More information about the webkit-dev
mailing list