[webkit-dev] RenderStyleConstants.h - enum naming conventions?

[Glenn Adams]

On Fri, Aug 24, 2012 at 2:58 PM, Eric Seidel <eric at webkit.org> wrote:

> Sorry, I was unclear.  I haven't seen someone create a new enum using
> E in years.  LineBreakType or similar would be better than
> ELineBreakType.
>
> > On Thu, Aug 23, 2012 at 11:53 PM, Glenn Adams <glenn at skynav.com> wrote:
> >> enum LineBreak { LineBreakAuto, LineBreakLoose, LineBreakNormal,
> >> LineBreakStrict, LineBreakAfterWhiteSpace };
>

Thanks, I will take that as a +1 to go with changing EKHTMLLineBreak to:

enum LineBreak { LineBreakAuto, LineBreakLoose,
LineBreakNormal, LineBreakStrict, LineBreakAfterWhiteSpace };

[or if there is a name conflict on LineBreak, then will use LineBreakType]
(whether the suffice 'Type' is included also seems somewhat irregular)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120824/ba1497e7/attachment.html>