[webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

Bruno Abinader brunoabinader at gmail.com
Tue Aug 21 13:02:57 PDT 2012

On Sat, Aug 18, 2012 at 10:20 PM, Tim Horton <timothy_horton at apple.com> wrote:
> Without looking at the code, I vaguely think that CSSPropertyWebkitTextDecorationLine comes from a generated file that might not rebuild when it's supposed to. You should try a clean build and see -- there've been a few problems with this recently (I ran into it when switching flexbox and regions/exclusions on and off a lot a few months ago, and a colleague ran into it again recently in a similar situation).

Is there a way to force the EWS build bots to do a clean build? I'm
frequently obtaining build failures on gtk, mac and win due to this
refuse to rebuild these generated files (ie.
https://bugs.webkit.org/show_bug.cgi?id=94094#c9 ). From the output
you can see that both Source/WebCore/css/CSSValueKeywords.in and
Source/WebCore/css/CSSPropertyNames.in were supposed to generate the
new values, but aren't, causing the failures.

Best regards,

Bruno de Oliveira Abinader

More information about the webkit-dev mailing list