[webkit-dev] New runtime setting: css3TextDecoration

[Bruno Abinader]

On Tue, Aug 14, 2012 at 3:06 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Tue, Aug 14, 2012 at 11:56 AM, Julien Chaffraix
>> > * If your feature is protected by an ENABLE flag, vendors that want to
>> > ship release software can turn it off.
>>
>> That's true, except that the original thread didn't mention any form
>> of feature flag [1]. Nobody objected at the time and thus patches that
>> implemented part of the spec arrived on bugzilla: prefixed but not
>> protected by any flag.
>
> I had certainly assumed that this was done under a new build flag. If that
> were not the case, I expected relevant reviewers to r- those patches. Maybe
> this was a bad assumption to make.

I've studied CSS Region implementation and basically it contains both
compile and runtime flags: The former gets enabled by default while
the latter gets disabled, so we can still catch compile-time code
errors while not automatically exposing the feature to the web without
explicitly enabling the setting. I guess we can implement this feature
the same way?

I do have a working patch with compile flag implementation [1] . The
"-webkit-text-decoration-line" code works most of the time as an alias
to original "text-decoration", so it was assumed that no special build
flag was required at that time. This is fixed also in [1]. The runtime
flag patch [2] works on top of [1], so we end up with the same
behavior as CSS region implements.

Links:
[1] https://bugs.webkit.org/show_bug.cgi?id=93863
[2] https://bugs.webkit.org/show_bug.cgi?id=93966

-- 
Bruno de Oliveira Abinader