[webkit-dev] check-webkit-style should remind folks to update the results for run-bindings-tests

[Kentaro Hara]

> Also note Maciej's proposal about moving it to a build step.

I am for this idea, but in that case maybe I want the option to ignore
run-bindings-tests in the build.

When we change CodeGenerator*.pm, we repeat try & error many times
until build succeeds. If we needed to update run-bindings-tests for
each try, that would be troublesome:)


On Mon, Apr 9, 2012 at 9:25 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> Also note Maciej's proposal about moving it to a build step.
>
> Either way, it shouldn't be ran as a test step on build bots.
>
> - Ryosuke
>
>
> On Mon, Apr 9, 2012 at 9:18 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>
>> We have discussed this
>> before: https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html
>>
>> A better change would be for us to generate the diff on EWS, and get rid
>> of binding tests step from build bots since they aren't really testing
>> anything. The primary use case of run-bindings-tests is to see the diff
>> before/after a code generator change and it has no business running on the
>> bot or in check-webkit-style.
>>
>> - Ryosuke
>>
>> On Mon, Apr 9, 2012 at 6:39 AM, Vineet Chaudhary <rgf748 at motorola.com>
>> wrote:
>>>
>>> Hi All,
>>>
>>>
>>> It is observed that if changes are made in Codegenerator*.pm we need to
>>> rebase results of run-bindings-tests.
>>>
>>> Many times authors forgot to update these binding results.
>>>
>>>
>>> IMO we should add check in ./check-webkit-style  to warn/(give a chance)
>>> author to run run-bindings-tests if Codegenerator is modified.
>>>
>>> I have filed bug for this https://bugs.webkit.org/show_bug.cgi?id=83354 .
>>>
>>>
>>> Please let me know if any suggestions to make this change.
>>>
>>>
>>> Thanks,
>>> Vineet
>>>
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>



-- 
Kentaro Hara, Tokyo, Japan (http://haraken.info)