[webkit-dev] check-webkit-style should remind folks to update the results for run-bindings-tests

[Kentaro Hara]

[Sending from a correct mail address...]

>> IMO we should add check in ./check-webkit-style  to warn/(give a chance)
>> author to run run-bindings-tests if Codegenerator is modified.

+1 to the idea. I think that it would make sense to warn if any file
under WebCore/bindings/ is changed.

Another idea might be to run ./run-bindings-tests in
./check-webkit-style (instead of warning), but it is too heavy (it
takes 5~ seconds).

run-bindings-tests are just for showing reviewers what changes the
patch is going to make. Even if run-bindings-tests fail, it is not a
serious problem. Thus, the build bots ignore the run-bindings-tests
results. Consequently, people sometimes forget to update the results.
I've been manually rebaselining run-bindings-tests results more than
once a week:)


> On Mon, Apr 9, 2012 at 3:39 PM, Vineet Chaudhary <rgf748 at motorola.com> wrote:
>> Hi All,
>>
>>
>> It is observed that if changes are made in Codegenerator*.pm we need to
>> rebase results of run-bindings-tests.
>>
>> Many times authors forgot to update these binding results.
>>
>>
>> IMO we should add check in ./check-webkit-style  to warn/(give a chance)
>> author to run run-bindings-tests if Codegenerator is modified.
>>
>> I have filed bug for this https://bugs.webkit.org/show_bug.cgi?id=83354 .
>>
>>
>> Please let me know if any suggestions to make this change.
>>
>>
>> Thanks,
>> Vineet
>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
>
> --
> Kentaro Hara, Tokyo, Japan (http://haraken.info)

-- 
Kentaro Hara, Tokyo, Japan (http://haraken.info)