[webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

[Adam Barth]

2012/4/5 Alexey Proskuryakov <ap at webkit.org>:
> 05.04.2012, в 01:08, Adam Barth написал(а):
>
>> Based on this information, I've posted a patch that limits the -apple-
>> and -khtml- vendor prefixes to ENABLE(DASHBOARD_SUPPORT):
>>
>> https://bugs.webkit.org/show_bug.cgi?id=83256
>>
>> This approach lets ports that wish to remain compatible with Dashboard
>> widgets continue to support these prefixes while also letting ports
>> that aren't constrained by dashboard widgets disable them, hopefully
>> lessening their use on the broader web.
>
> Guarding on ENABLE(DASHBOARD_SUPPORT) will make it so that these names will be available in Safari on Mac, in every Mac application that uses WebKit, but not in Safari on Windows or iOS, and not in other WebKit based browsers such as Chrome. I don't think that this level of fragmentation is good.
>
> We normally guard Dashboard-only quirks with settings->usesDashboardBackwardCompatibilityMode().

I attempted to implement this approach in
<https://bugs.webkit.org/attachment.cgi?id=136093&action=prettypatch>,
but I ran into a problem because cssPropertyID is a free function.
Requiring all the callers to pass in a Settings object seems
undesirable.  Note: there are already a number of uses of
ENABLE(DASHBOARD_SUPPORT) in CSSParser.cpp, and none of them check
usesDashboardBackwardCompatibilityMode().

My current plan is to introduce a new ENABLE macro that ports can set
as they desire.

Adam