[webkit-dev] Early deletion of DocumentLoader instances

Steve Block steveblock at google.com
Thu Sep 22 11:07:00 PDT 2011

It looks like this was resolved in
https://bugs.webkit.org/show_bug.cgi?id=61494, which resulted in
http://trac.webkit.org/changeset/87756. I can't access the bug, so I'm
following up here ...

This change is causing problems on Android. We use the
AllowLocalLoadsForLocalAndSubstituteData policy but
Document::initSecurityContext() no longer calls
securityOrigin().grantLoadLocalResources() because of the check for
'm_frame->document() == this' added by this change in

In DocumentWriter::begin(), we create a new Document, and the Document
constructor calls Document::initSecurityContext(). However, at this
point the Frame has not yet been updated with the new Document, so we
fail the new check in DocumentLoader::loader(). However, it looks like
the Frame does have the correct DocumentLoader at this point. So it
seems wrong for Document::loader() to return 0 and seems that the new
check isn't valid in all cases? Or am I missing something? Any advice
would be greatly appreciated.


Google UK Limited
Registered Office: Belgrave House, 76 Buckingham Palace Road, London SW1W 9TQ
Registered in England Number: 3977902

More information about the webkit-dev mailing list