[webkit-dev] ENABLE flag cleanup strawman proposal

noam.rosenthal at nokia.com noam.rosenthal at nokia.com
Wed Sep 14 23:42:15 PDT 2011

On Sep 15, 2011, at 3:25 AM, ext Adam Barth wrote:

> I wonder if we should combine all the flags that are disabled only to
> reduce binary size.
One thing that can be done, is to combine them in the build-bot level, like the --minimal flag in build-webkit. Combining flags to something cryptic like REDUCE_BINARY_SIZE (I know you didn't suggest that one :)) would not seem readable, but "Change 67777 broke the reduced-binary-size build" does, to me.
We've done that with the Qt minimal bot to some success. It doesn't reduce as much complexity as removing the flag altogether, but it does keep people from putting, for example, XSLT code outside the ENABLE_XSLT flag without a notification.

> Adam
> On Wed, Sep 14, 2011 at 5:21 PM, Loïc Yhuel
> <loic.yhuel_ext at softathome.com> wrote:
>> Do we know what would be the code size increase due to enabling all these
>> flags ?
>> Library size can be a constraint on embedded systems.
>> ENABLE(INSPECTOR) : On many embedded systems, it won't be used (except
>> during development), and would be blocked by the firewall or stubbed for
>> security reasons.
>> ENABLE(XSLT) : It would add libxslt dependency, so even more overhead.
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list