[webkit-dev] make-script-test-wrappers not being maintained

Ryosuke Niwa rniwa at webkit.org
Thu Sep 8 10:16:22 PDT 2011

Yeah, if the script is located at LayoutTests/resources/js-test.js for
example, all I need to type is
<!DOCTYPE html>
<script src="../resources/js-test.js"></script>
<!DOCTYPE html>
<script src="../../resources/js-test.js"></script>

that seems like a trivial step to me. However, I've always felt having to
add var successfullyParsed = true to be annoying. Can we get rid of this
variable altogether since any parsing error shows on console anyway?

- Ryosuke

On Thu, Sep 8, 2011 at 10:11 AM, Ojan Vafai <ojan at chromium.org> wrote:

> On Thu, Sep 8, 2011 at 12:58 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> On Thu, Sep 8, 2011 at 12:41 AM, Maciej Stachowiak <mjs at apple.com> wrote:
>>> Do you have an idea for how to avoid needing to adjust the number of
>>> "../" path segments in the path to the harness? That's the most annoying
>>> step of the current copy/paste solution, and it does not seem like
>>> simplifying the boilerplate as you suggest resolves that issue.
>> I personally don't think it be that annoying. Usually, I can find another
>> test that uses the same framework in the same depth.  I'd be more annoyed by
>> having to run a script on Terminal (and presumably giving it a relative path
>> from LayoutTests).
> Like Ryosuke, I haven't found this to be much of a nuisance in practice
> with dump-as-markup.js since there's only one path you need to fix up.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110908/cfad38b1/attachment.html>

More information about the webkit-dev mailing list