[webkit-dev] make-script-test-wrappers not being maintained

Jarred Nicholls jarred at sencha.com
Thu Sep 8 08:05:58 PDT 2011


On Thu, Sep 8, 2011 at 11:04 AM, Tom Zakrajsek <tomz at codeaurora.org> wrote:

> Wouldn't that make it so that the tests would *only* work in DRT?


Yeah that's not good ;)


>
>
>
> On 09/08/2011 07:58 AM, Eric Seidel wrote:
>
>> We could also teach DumpRenderTree to lie about what "/" is, so we
>> could include the scripts like this:
>>
>> <script href=/fast/js/resources/js-**test-pre.js>
>>
>> On Thu, Sep 8, 2011 at 1:14 AM, Adam Barth<abarth at webkit.org>  wrote:
>>
>>> On Thu, Sep 8, 2011 at 12:41 AM, Maciej Stachowiak<mjs at apple.com>
>>>  wrote:
>>>
>>>> Do you have an idea for how to avoid needing to adjust the number of
>>>> "../"
>>>> path segments in the path to the harness? That's the most annoying step
>>>> of
>>>> the current copy/paste solution, and it does not seem like simplifying
>>>> the
>>>> boilerplate as you suggest resolves that issue.
>>>>
>>> One approach is to have an inline script that examines the URL and
>>> sets the base URL appropriately:
>>>
>>> <script>
>>> document.write('<base href="' + location.href.substr(0,
>>> location.href.lastIndexOf('**LayoutTests/') + 'LayoutTests/'.length) +
>>> '">');
>>> </script>
>>>
>>> Of course, you could make the script more readable if you were willing
>>> to have it extend to more than one line.  If you wanted to get really
>>> fancy, you could restore the original base URL after loading the
>>> appropriate test harness scripts.
>>>
>>> Adam
>>> ______________________________**_________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev<http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev>
>>>
>>>  ______________________________**_________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev<http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev>
>>
> ______________________________**_________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev<http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev>
>



-- 
................................................................

*Sencha*
Jarred Nicholls, Senior Software Architect
@jarrednicholls
<http://twitter.com/jarrednicholls>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110908/9c1f1c28/attachment.html>


More information about the webkit-dev mailing list