[webkit-dev] make-script-test-wrappers not being maintained

Alexey Proskuryakov ap at webkit.org
Wed Sep 7 17:58:40 PDT 2011


07.09.2011, в 17:15, Alexey Proskuryakov написал(а):

>> IMO, it's only undesirable because of the current amount of boilerplate. We could change script test JS code so that the only boilerplate you need is:
>> <!DOCTYPE HTML>
>> <script src="path/to/test-harness.js"></script>
> 
> I don't care much personally, and only want to unblock <https://bugs.webkit.org/show_bug.cgi?id=66357>. Hopefully, this patch doesn't make it harder to improve the boilerplate later, and remove the script if its benefit seems too minor at this point.

On a second thought, I think that I would likely use the script myself even if the boilerplate was simpler. That's not all that's needed - you also need at least <div id="console"></div>, "var successfullyParsed = true;", and a few structural elements. Typing all that is difficult - and if you copy/paste, it doesn't really matter how much boilerplate there is.

Also, making the boilerplate more complicated and dynamic can unexpectedly affect tests.

- WBR, Alexey Proskuryakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110907/c27cabc4/attachment.html>


More information about the webkit-dev mailing list