[webkit-dev] Change to style guideline: should use type& instead of type* for out arguments

Ryosuke Niwa rniwa at webkit.org
Mon Oct 10 11:01:43 PDT 2011


This is nothing to do with RefPtr.

- Ryosuke

On Mon, Oct 10, 2011 at 10:56 AM, David Levin <levin at chromium.org> wrote:

> It feels like the material about RefPtr belongs here:
> http://www.webkit.org/coding/RefPtr.html instead of the style guide since
> that is where everything else about how to properly use RefPtr/PassRefPtr
> is.
>
>
> On Mon, Oct 10, 2011 at 10:42 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>
>> FYI, a patch has been posted to
>> https://bugs.webkit.org/show_bug.cgi?id=69766 to make this change along
>> with "get" prefix convention for getters that return values via out
>> arguments.
>>
>> - Ryosuke
>>
>> On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>
>>> Hi,
>>>
>>> It came to my attention that some people are using raw pointers to pass
>>> out-arguments (e.g. bug 69366). In my understanding, we use pass by
>>> reference for out arguments when they have to be modified in callees.
>>>
>>> If there's no objection, I'm going to file a bug & upload a patch to
>>> state this explicitly in the style guideline.
>>>
>>> Best,
>>> Ryosuke Niwa
>>> Software Engineer
>>> Google Inc.
>>>
>>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20111010/a74b3075/attachment.html>


More information about the webkit-dev mailing list