[webkit-dev] : Modifying expected.txt of layout testcases

Vamshi vnampally at innominds.com
Mon Oct 10 06:35:50 PDT 2011

Hi All,

I proposed patch for the bug ID:20040, 
<https://bugs.webkit.org/show_bug.cgi?id=20040> which resulted in 
failure of few layout testcases. After analysis, I found that the 
expected.txt needs to be modified in order to make the test cases pass. 
because, my patch is to fix the "extra" vertical spacing across table 
sections. Hence it will definitely change the size of the tables and its 
parent render box and render layers. Hence the test cases were failing.
I am able run layout test cases for chromium-Linux, I guess the same 
test cases would fail on other platforms too.
So I have the following doubts to proceed further:

1. Should I request some of the reviewers to review my patch before I 
actually go and modify all expected.txt files ?
2. Do i need to modify expected.txt files for all the platforms? If so, 
Is it required to make set up for each of the platforms?

Vamshi Krishna.N

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20111010/cf030477/attachment.html>

More information about the webkit-dev mailing list