[webkit-dev] EWS bots don't run when missing binary data in diff [was Re: Style bot complains of missing binary data in diff when deleting .png test results]

[David Levin]

On Wed, Nov 30, 2011 at 5:42 PM, Alan Stearns <stearns at adobe.com> wrote:

>  David,
>
>   This is a bug where I accidentally turned on a pixel result, then needed
> to remove the .pngs when I fixed the problem:
>
> https://bugs.webkit.org/show_bug.cgi?id=73343
>
>   The patch had two lines like this:
>
> Binary files
> a/LayoutTests/platform/efl/fast/regions/no-split-line-box-expected.png and
> /dev/null differ
>
>   Which resulted in this output from style-queue:
>
> Failed to run "[u'/mnt/git/webkit-style-queue/Tools/Scripts/svn-apply',
> u'--force']" exit_code: 9
>
> Error: the Git diff contains a binary file without the binary data in
> line: "Binary files
> a/LayoutTests/platform/efl/fast/regions/no-split-line-box-expected.png and
> /dev/null differ".  Be sure to use the --binary flag when invoking "git
> diff" with diffs containing binary files. at
> /mnt/git/webkit-style-queue/Tools/Scripts/VCSUtils.pm line 667, <ARGV> line
> 45.
>

Ah, your issue is with how the patch is applied and that it fails and it
causes the style bot to fail.

This seems like a general EWS issue. It would be good to run the builds run
for your patch as well even though you didn't have the binary in there.


dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20111130/827e3771/attachment.html>