[webkit-dev] Cleaning up directories in WebCore
Kenneth Rohde Christiansen
kenneth.christiansen at gmail.com
Fri Nov 18 02:17:15 PST 2011
I also agree with moving Platform out. That would make the
dependencies easier to understand and hopefully avoid more layering
On Fri, Nov 18, 2011 at 11:06 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> What's the benefit of this re-org?
> Is it really worth the trouble to move these files around? This would mean
> that we may need to navigate multiple pages on trac to see revision logs.
> Other tools may suffer from such file moves as well. I remember I had to
> create new git checkout when Source move happened.
> Also, moving inspector, notifications, etc... under Features would mean that
> folks working on those components now need to type at last 2-3 more
> characters even with tab completion to find their files. Isn't that worse
> than the current situation?
> And how would one decide whether a directory belongs to WebCore vs.
> Though I do agree that moving manual-test out of Source/WebCore seems like a
> good idea. It should probably live at trunk/ManualTests.
> - Ryosuke
> On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth <abarth at webkit.org> wrote:
>> I've been looking for ways to improve the hackability of WebCore, and
>> one thing that's been bothering me is the organization of our files.
>> It seems like we're due for a bit of "fall cleaning" for directories.
>> We've talked about some of these ideas before, but I wanted to put
>> them all in one email so we can see the big picture.
>> Below is a concrete proposal for moving some directories around. In
>> this approach, we'll have a "Features" directory to contain logically
>> self-contained features, like WebAudio and MediaStream, that are part
>> of the engine but that aren't tightly coupled with the DOM, Layout, or
>> Rendering. We'd also have a new "events" directory in "dom" to
>> contain the large number of event-related files that we've accreted.
>> The "history" directory would move into "page" (we could actually
>> merge these directories because history is so small). Finally,
>> "manual-tests" and "platform" would move out of WebCore entirely.
>> Features/ <-- New folder for (roughly) self-contained features
>> manual-tests/ <-- Move outside of Source
>> events/ <-- New folder for the 106 files that match dom/*Event*
>> history/ <-- Moved from top-level
>> platform/ <-- Move to Source/Platform
>> The "html" and "page" directories also contain a bunch of unrelated
>> files (presumably because they're attractive locations for folks to
>> add files). Once we do the directory moves above, I'll send out
>> another proposal for cleaning up those directories a bit.
>> Please let me know if you have any thoughts.
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
Kenneth Rohde Christiansen
Application and Service Frameworks, Nokia Danmark A/S
Phone +45 4093 0598 / E-mail kenneth.christiansen at gmail.com
More information about the webkit-dev