[webkit-dev] "Tools/Scripts/webkit-patch rebaseline-expectations" does not launch html comparison page?
epoger at chromium.org
Tue Nov 8 12:00:54 PST 2011
Perhaps I should approach this from a different angle:
What is the recommended procedure for:
- generating new baseline images for a few dozen failing tests, on various
- visually inspecting them to make sure they're not bogus
- committing them, along with test_expectations changes, to the WebKit repo
On Tue, Nov 8, 2011 at 2:48 PM, Eric Seidel <eric at webkit.org> wrote:
> I believe that tool just got nuked. Seems the Wiki page should as well:
> On Tue, Nov 8, 2011 at 9:09 AM, Adam Barth <abarth at webkit.org> wrote:
> > On Tue, Nov 8, 2011 at 7:06 AM, Elliot Poger <epoger at chromium.org>
> >> I have just run "Tools/Scripts/webkit-patch rebaseline-expectations".
> >> are plenty of image rebaseline changes ("svn status" yields 792
> lines!), but
> >> I'm not seeing the promised html page to compare old and new baselines.
> > Correct. It does not launch a comparison page.
> >> The docs at http://trac.webkit.org/wiki/Rebaseline indicate that such
> >> html page will be launched by default.
> > That's documentation for a different tool.
> >> Is there some flag I have to pass to make this happen?
> > There is no flag.
> > My plan was to add the ability to take an arbitrary patch in the
> > working copy and show a pretty-diff like view of how the patch effects
> > layout test results. I haven't had time to implement that yet. If
> > you're interested in adding that feature, let me know and I'll help
> > you get started.
> > Adam
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev