[webkit-dev] Early deletion of DocumentLoader instances

Maciej Stachowiak mjs at apple.com
Wed May 25 22:56:05 PDT 2011


On May 25, 2011, at 9:30 PM, Adam Barth wrote:

> 
> Reading my comments on the bug, I was happy that the document had a
> pointer to the DocumentLoader.  My apologies for misunderstanding the
> ownership relations between these objects.  I thought that
> DocumentLoader had Document-lifetime, but it appears that it has
> neither Document-lifetime nor Frame-lifetime.
> 
> The correct fix is likely to change the way to locate the writer() as follows:
> 
> - document->loader()->writer()
> + frame->loader()->activeDocumentLoader()->writer()
> 
> I'll put this at the top of my TODO list for Friday.  (Unfortunately,
> I'm at the W2SP workshop tomorrow and can't fix the issue
> immediately.)

Thanks for the suggestion. I think Brady can probably take a shot at this before Friday, but we'll keep you in the loop.

Cheers,
Maciej



More information about the webkit-dev mailing list