[webkit-dev] Why is gtest in the Source directory?

Kevin Ollivier kevino at theolliviers.com
Thu May 12 12:50:49 PDT 2011

On May 12, 2011, at 11:48 AM, Darin Adler wrote:

> On May 12, 2011, at 11:33 AM, David Levin wrote:
>> Layout/  # Would be nice to have a better name since these test much
>> more than Layout
>> DumpRenderTreeTests?
>> Integration?
>> AutomatedHtmlTests?
> Here are some characteristics of these tests that may help us name the directory:
>     1) This is the primary suite of WebKit tests.
>     2) These tests are all automated.
>     3) These tests all include an expected result (broadly including future addition of reftests).
>     4) These tests are regression tests; most are designed to catch any changes in behavior, not just detect failure.
>     5) These tests consist of HTML or SVG markup, with CSS and JavaScript, much like webpages in the wild.
>     6) Most of these tests can also be run by opening them in a web browser.
>     7) Most of these tests are designed to test end-to-end, although some are more like unit tests.
> I don’t think they should be named after DumpRenderTree because that name is itself a misnomer.
> I think that (7) above does fit with the name Integration, but that name still doesn’t work so well for me.
> Despite (5) above I don’t love the idea of having HTML in the name when we can accommodate SVG tests too.

What about just "Web", "Engine" or "WebPages"? If SVG complicates the naming issue, maybe it could be moved to its own top level directory? That would avoid any confusion over where one would expect to find the SVG tests. 


>     -- Darin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110512/77be8ff2/attachment.html>

More information about the webkit-dev mailing list