[webkit-dev] process for unreviewed commits

Martin Robinson mrobinson at webkit.org
Fri Mar 4 10:10:03 PST 2011


On Thu, Mar 3, 2011 at 11:58 PM, Ojan Vafai <ojan at chromium.org> wrote:
> This isn't a big deal either way, but I noticed
> that http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit
> lists the following as the process for unreviewed commits: "Unreviewed
> commits should include a line saying "Unreviewed." in place of the "Reviewed
> By..." line in each ChangeLog entry."
> The "Unreviewed" bit is news to me. I thought it was assumed that if there's
> no "Reviewed By..." line then it was committed unreviewed and, in fact, that
> was preferred to adding the "Unreviewed" line.

This was also discussed some months ago, though perhaps things have
changed since then:
https://lists.webkit.org/pipermail/webkit-dev/2010-July/013712.html

It seems that the consensus was that non-bot commits should not
include "Unreviewed" or "Not reviewed." Disclaimer: I have no
preference one way or the other, but thought I should link to the
previous discussion.


More information about the webkit-dev mailing list