[webkit-dev] process for unreviewed commits

Eric Seidel eric at webkit.org
Fri Mar 4 00:37:53 PST 2011

The unreviewed bit is currently used by the scripts (like the
commit-queue) to help them understand that the patch is intentionally

I don't know what the "official" process is.  But certainly some
amount of "this is intentionally missing a review" information is
useful for the commit-queue.  Feel free to change how that's conveyed.


On Thu, Mar 3, 2011 at 11:58 PM, Ojan Vafai <ojan at chromium.org> wrote:
> This isn't a big deal either way, but I noticed
> that http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit
> lists the following as the process for unreviewed commits: "Unreviewed
> commits should include a line saying "Unreviewed." in place of the "Reviewed
> By..." line in each ChangeLog entry."
> The "Unreviewed" bit is news to me. I thought it was assumed that if there's
> no "Reviewed By..." line then it was committed unreviewed and, in fact, that
> was preferred to adding the "Unreviewed" line.
> Ojan
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list