[webkit-dev] A tip for committers

[Oliver Hunt]

Can the style bot be made aware of .png at least and complain if you don't set the right flags?

--Oliver

On Mar 3, 2011, at 6:45 AM, Adam Roben wrote:

> All committers are encouraged to follow the instructions I just added to <http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit>:
> 
>> Subversion has a handy feature called auto-props that will ensure that new binary files you add to the repository are given the correct MIME type. To set this up, find the following two lines in ~/.subversion/config and uncomment them:
>> 
>> enable-auto-props = yes
>> 
>> *.png = svn:mime-type=image/png
>> 
>> Note that this will work even if you use git-svn to commit changes to WebKit.
> 
> This will prevent your webkit-changes emails from being filled with gobbledy-gook like this:
> 
>> +\x89PNG
>> +
>> +
>> +IHDR X'bKGD\xFF\xFF\xFF\xA0\xBD\xA7\x93 IDATx\x9C\xED\xDD{\x90\x95\xE5}\xC0\xF1\xF7\xC8\xCBeq\x97\x8B\x90%q) \xC2RASk:8\x89\xB9\xD0L\xB5Tt'\xEB0:\xA3i
>> +4b
\xA3S#"SsA\x89Q[\xB0x
	jiA#7\x89\xB2Fv\xB9(7Yݷ\x9C\x99\x9D\xCD^\xEF.?\xF4\xF3\xF9\xEBx\xF6}\xDF\xE7y\xDEs\x8E\xFB\x9D\xF7
\xCE\xE6\xD24M\x88sډ\x9E\xC0g\x8D\xC0&\xB0\x82	,\x80` \x98\xC0&\xB0\x82	,\x80` \x98\xC0Vt,;\xEF޽\xFB\xE0\xC1\x83EEE\xBD{\xF7nx\xBBUy\xF7\xDDw\xB7o\xDF>lذ\xAE]\xBB6\xFDiuuummmII\xC9駟ު\xC3VUU%Iҽ{\xF7Ν;\xB7j\xC7cת\xA1\xDB|\xDEZ\xA5ͧ\xB1\x91\x96f\xBBgϞ\xB4k׮O\x9F>Y\xB6\xCF\xE2\xFD\xF7\xDF?t\xE8P\xA7N\x9Dz\xF4\xE8\xD1\xDA}[\x9Aϧ\xE0x<\xA0Q\x9F\x9ALW\xB0\xDE{\xEF\xBD\xFA\xA7z\xE6\x99gݿ}\xFB\xF6\xDBn\xBB\xED\xE2\x8B/nt;\xBB|\xF0_\xFE\xE5_fϞ\xFD\xEC\xB3\xCF6\xBB\xC1\xBAu뮸⊟\xFC\xE4'\xAD:l\x92$/\xBF\xFC\xF2\xC0\x81\xFB\xDB߶v\xC7cת\xA1\xDBv\xDEZ\xABͧ\xB1\x91\x96f\xFB\xCE;\xEF\xFC\xE8G?>|x\xC6\xED\xB3ضm\xDB5\xD7\\xF3\xDD\xEF~\xB7\xF0f\xCF?\xFF\xFC\xFC\xC7d\x9COk5{\xF0Ž\xC7Z\xE0\xE1k\xC3
\xF8d
>> +\xAC_\xFF\xFA\xD7s\xE7\xCE\xFD\xE7\xFE\xE7F\xF7\x8F1\xE2K_\xFAR\xD3\xDB
<x\xF0\x8E;\xEE\x98:u\xEA\xBD\xF7\xDE;dȐF?\xCD\xFF\xEA\xB1cǞu\xD6Y\xAD:l\xDE\xF8\xF1㋋\x8B۰\xE3\xB1k\xD5\xD0m8om\xD0\xE6\xD3\xD8HK\xB3\xBD\xF0\xC2/\xBD\xF4\xD2\xEC\xDBg1r\xE4ȁ
u\xB3G}\xF4\xDF\xFF\xFD\xDF3\xCE'\xA3\xFA\xBF\x80\xDE\xEC\xC1+\xBC\xE4\xD6\xFEm\xF5\xA3\xBE
>> +\xDA0C>\x99\xEB\x99g\x9E\xB9\xFB\xEE\xBB_}\xF5\xD5\xD7_=p\xEC\xED۷\xF8\xE1\x87%%%\xA5\xA5\xA5\x8D~\x95>\xF9\xE4\x933g\xCE<\xF6!N;\xED\x84}\xC8\xEC\xFD\xB9\xF2\x8B_\xFCbݺu\x81l\xF8܋=xk\x9F\xD5Y\xB6_>!\x8E\xFE\xACu\xEB\xD6UTT\{\x{DD77}\xDCr˜9s~\xFAӟ\xB6a\x98Ç?\xF5\xD4Suuu\xDF\xFAַ:u\xEA\x94$ɞ={\xF2o>\xF9䓝;w\xBE\xFA\xEA\xABs\xB9\~\xE3-[\xB6\xDCy\xE7\x9DÆ
>> +{\xEC\xB1\xC7ƍ\x97$I\xBBv\xED֮]\xFB\xEC\xB3\xCFv\xEC\xD8qҤIݺu\xCBo\xB9{\xF7\xEEy\xF3\xE6%Ir\xDDuםq\xC6M\xC7ݷo\xDF̙3kkk'L\x98PVVV`>\xAF\xBE\xFA\xEA\xE6͛\x93$\xE9ٳ\xE7\xF0\xE1ß{\xEE\xB9$I*++\xCF?\xFF\xFCfڱc\xC7c\x8F=\xF6\xC1\x9Cs\xCE9\xD7_}\xFE Y\x86>ꜛ\xCE\x{DDFF}\xFDm]]]\x92$\x83\xBE\xE0\x82\xEA\xB7|\xF7\xDDwW\xAE\\x99$\xC9СC
> 
> (My hat is off to those brave souls who keep the bots green by rebaselining tests. My hat will be even more off to you if you follow this tip!)
> 
> -Adam
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev