[webkit-dev] About 165 Editing Tests Require Rebaselines per Bug 51389

Maciej Stachowiak mjs at apple.com
Tue Mar 1 22:39:35 PST 2011


On Mar 1, 2011, at 10:21 PM, Ryosuke Niwa wrote:

> Hi,
> 
> When is the best time to land a massive patch that requires rebaselines of about 165 tests?
> 
> I'm going to land my patch for the bug 51389 within the next 24 hours but the patch is 688KB
> and rebaselines 186 tests, of which 165 are Mac specific. And it's likely that we need to do
> a similar number of rebaselines (approx. 165) on other platforms as well.
> 
> Since I'm in JST now, I can land it either in the late evening or early morning.

Why does a fix for an assertion failure require so many test results to change? Perhaps the bug should be retitled to describe the problem that requires such a wide-ranging behavior change.

Regards,
Maciej


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110301/724d883c/attachment.html>


More information about the webkit-dev mailing list