[webkit-dev] The case for disallowing alerts in unload, redux

Ojan Vafai ojan at chromium.org
Mon Jun 27 15:36:38 PDT 2011

On Mon, Jun 27, 2011 at 3:17 PM, Alexey Proskuryakov <ap at webkit.org> wrote:

> 27.06.2011, в 14:03, Darin Fisher написал(а):
> > I think we can make this behavior a Setting, and then certainly each
> embedder of WebKit
> > can decide how prominently to surface this option.  For Chrome, we'll
> probably either make
> > it be a command line flag, or we would just leave out the option
> entirely.
> Perhaps I'd be less unhappy about this change if the flag were off in
> layout tests, so that we didn't have to change them all to remove alert() in
> unload.

That patch was scrapped. Now alerts during unload handlers will just log to
the console, so the alerts can be left in. The expected results for the
tests will change a bit though since the message being logged is different.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110627/10b31540/attachment.html>

More information about the webkit-dev mailing list