[webkit-dev] 194 bugs in pending-commit
mustaf.here at gmail.com
Mon Jun 20 03:18:43 PDT 2011
On a similar note of bug cleanup, I have also seen lot of issues which are
still in Unconfirmed state, even though the bug analysis says either the
issue is not reproducible etc etc.
So, Is there a way to clean up such bugs so that they don't unnecessarily
come up in queries. What is the traditional procedure we follow in such
On Sun, Jun 19, 2011 at 10:18 AM, Eric Seidel <eric at webkit.org> wrote:
> webkit-patch upload clears all flags when obsoleting a patch. We
> could make it not clear r- if you like. I know of no way to construct
> a query like http://webkit.org/pending-commit in our current bugzilla
> without clearing r+ on obsolete patches/closed bugs. We clear flags
> (specifically r+) to make the life of those going through
> http://webkit.org/pending-commit easier (like sever folks tried to do
> this afternoon).
> Similarly, our current bugzilla doesn't automatically clear r? on
> closed bugs. So we have webkit-patch clean-review-queue to do that.
> The history information for any bug is always easily accessed via the
> "history" link in the upper-right corner of a bug, like:
> On Sat, Jun 18, 2011 at 9:01 PM, Antonio Gomes <tonikitoo at gmail.com>
> > IIRC, Mozilla's bugzilla can "hide" obsolete patches (?). If so, why can
> > webkit's bugzilla?
> > I actually do not like the way the review flags are cleared today only in
> > order to make the tools and pending-xxx pages happier. IMO the review
> > give much about the history of the bug. In that matter, I dislike
> > webkit-patch's ways of clearing "r-" flags of patches while it marks it
> > obsolete and uploads a new one. Reason: an easy-to-see r-'ed patch is
> > helpful to me to understand the chronological progresses in the bug.
> > What is the reason for clearing r- flag while uploading a new one,
> > of only making it obsolete?
> > On Sat, Jun 18, 2011 at 2:23 AM, Adam Barth <abarth at webkit.org> wrote:
> >> On Fri, Jun 17, 2011 at 11:13 PM, Peter Kasting <pkasting at chromium.org>
> >> wrote:
> >> > On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth <abarth at webkit.org>
> >> >> 2) Mark the patch as obsolete / clear the review flag if we're not
> >> >> going to land the patch.
> >> >
> >> > Does the slash mean "do both"? I
> >> > have https://bugs.webkit.org/show_bug.cgi?id=47036 on that list and
> >> > only
> >> > r+ed patch on it is already marked obsolete.
> >> Yeah, Bugzilla kind of sucks. That page isn't smart enough to hide
> >> the obsolete patches. If you have EditBugs, you can run "webkit-patch
> >> clean-pending-commit", which will automatically remove the review
> >> flags from obsolete patches. Eric and I have been meaning to having
> >> one of the bots do that periodically, but we haven't set that up yet.
> >> Adam
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> > --
> > --Antonio Gomes
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev