[webkit-dev] review flags (was bugs in pending-commit)

Antonio Gomes tonikitoo at gmail.com
Sun Jun 19 14:09:44 PDT 2011

Hi Darin. Few comments inlined.

On Sun, Jun 19, 2011 at 2:31 PM, Darin Adler <darin at apple.com> wrote:

> On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote:
> > I actually do not like the way the review flags are cleared today only in
> order to make the tools and pending-xxx pages happier. IMO the review flags
> give much about the history of the bug. In that matter, I dislike
> webkit-patch's ways of clearing "r-" flags of patches while it marks it as
> obsolete and uploads a new one. Reason: an easy-to-see r-'ed patch is very
> helpful to me to understand the chronological progresses in the bug.
> I agree that it would be clearer to leave review flags for clarity about
> the history of a patch. I also have been irritated by our work flow that
> involves clearing review flags to appease the tools.

I agree.

> However, even if we fixed everything so that was no longer necessary, I
> would still want a way to clearly communicate “this patch is known to be bad
> and not suitable for landing, despite the fact that a reviewer approved it
> at one point”.
And I also think that if we were redesigning the bug system it would be good
> if there was a way to communicate that a patch was landed other than having
> a bug marked RESOLVED, because people continue to put multiple patches in a
> single bug, and so the bugs state can’t really tell us the status of a
> patch.

See what I do myself in patches in bug
https://bugs.webkit.org/show_bug.cgi?id=50666 , for example. We could/should
teach toosl to do that.

--Antonio Gomes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110619/b422c30b/attachment.html>

More information about the webkit-dev mailing list