[webkit-dev] bugs.webkit.org UI housekeeping
wcarss at google.com
Mon Jun 13 11:38:41 PDT 2011
The suggestion of removing 'Formatted Diff' seems like the most reasonable -
but Ryosuke brings up a good point about highlighting. While it's cool that
a triple click+drag fixes his problem, a dev shouldn't have to know that to
get the desired functionality out of the review tool.
If the Formatted Diff gets removed, I think the Review tool should be
improved to support the case Ryosuke brought up. It's possible that someone
would want to select the code with or without line numbers, so I think it'd
be sensible if:
click+drag within code selects code only
click+drag beginning on line numbers and ending on line numbers opens a
click+drag beginning on line numbers and ending within ~150px of them opens
click+drag beginning on line numbers and ending ~150px into code or
something selects code with numbers
triple-click+drag on code selects code w/ line numbers
If this sounds reasonable to people, I'll see if I can work a patch up, so
there would be no reason to keep the Formatted Diff around.
On Mon, Jun 13, 2011 at 11:16 AM, Adam Barth <abarth at webkit.org> wrote:
> On Mon, Jun 13, 2011 at 11:11 AM, Wyatt Carss <wcarss at google.com> wrote:
> > Adam, you should write down a list of obscure-ui you use every day and
> > it to hackernews or something :P
> > As a newb looking at the webkit page, the difference between 'Review
> > and 'Formatted Diff' was just confusing -- their urls aren't even very
> > distinct: 'review patch' => 'review' while 'formatted diff' =>
> > 'prettypatch'.
> Do you have suggestions for better names?
> Review Patch | View Patch | Edit Details
> > On Sun, Jun 12, 2011 at 3:11 PM, Adam Barth <abarth at webkit.org> wrote:
> >> On Sun, Jun 12, 2011 at 3:07 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> >> > On Sun, Jun 12, 2011 at 3:02 PM, Adam Barth <abarth at webkit.org>
> >> >> Why can't you select lines by mouse drag?
> >> >
> >> > Because it's tricky to select the first line's indentation properly if
> >> > don't
> >> > mouse-down on the line number, at which point review tool starts
> >> > selecting
> >> > lines for commenting.
> >> Ah, I understand. I usually triple-click a line to select it and then
> >> drag, but I can see how that's obscure.
> >> Adam
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev