[webkit-dev] Adding ENABLE_FLEXBOX to WebCore

[Tony Chang]

Maybe, it would involve disabling CSS parser rules at runtime.  I don't
think we have any code that currently tries to do this.

On Wed, Jun 8, 2011 at 11:41 AM, Darin Fisher <darin at chromium.org> wrote:

> Is it possible for this feature to be enabled at runtime?
> On Jun 8, 2011 11:38 AM, "Adam Barth" <abarth at webkit.org> wrote:
> > New features should be tested incrementally as they are developed.
> > That means running them on build.webkit.org. The decision to ship a
> > feature is separate.
> >
> > Adam
> >
> >
> > On Wed, Jun 8, 2011 at 11:33 AM, Ojan Vafai <ojan at chromium.org> wrote:
> >> I don't think we want to ship this until we have a reasonably feature
> >> complete implementation of the spec and that we're convinced the spec is
> >> stable. I expect that in implementing this we'll find areas of the spec
> that
> >> need reworking, but at this point it's mainly blocked on implementation
> >> experience.
> >> I'm not sure it's worth setting a bot up just for this, although I'm not
> >> opposed to it. I expect we should have this shippable within a couple
> >> months.
> >>
> >> Ojan
> >> On Wed, Jun 8, 2011 at 11:21 AM, Adam Barth <abarth at webkit.org> wrote:
> >>>
> >>> Can't we just define ENABLE_FLEXBOX on one or more of the commonly
> >>> used ports and use the regular bots?
> >>>
> >>> Adam
> >>>
> >>>
> >>> On Wed, Jun 8, 2011 at 10:57 AM, Tony Chang <tony at chromium.org> wrote:
> >>> > Hi webkit-dev,
> >>> > I wanted to let you know that Ojan and I plan to add flexbox layout
> >>> > support
> >>> > to WebCore.  WebCore already supports an older flexbox implementation
> >>> > (display: box), but the new spec is designed to be easier for
> developers
> >>> > to
> >>> > understand and more powerful.  The old flexbox will still remain in
> >>> > WebCore
> >>> > since none of the CSS properties overlap with the new flexbox spec.
>  The
> >>> > spec can be found
> >>> >
> >>> > at: http://www.w3.org/TR/css3-flexbox/ (
> http://dev.w3.org/csswg/css3-flexbox/)
> >>> > This support will be behind the ENABLE_FLEXBOX feature define
> >>> > (https://bugs.webkit.org/show_bug.cgi?id=62049) and there is a meta
> bug
> >>> > tracking the feature's development
> >>> > (https://bugs.webkit.org/show_bug.cgi?id=62048).  I expect this
> feature
> >>> > to
> >>> > eventually be enabled by all ports.
> >>> > I am ready to setup a buildbot for tracking the compile and flexbox
> >>> > related
> >>> > layout tests.  Should I go ahead and get this added to
> >>> > build.webkit.org's
> >>> > waterfall?
> >>> > Thanks,
> >>> > Tony
> >>> >
> >>> > _______________________________________________
> >>> > webkit-dev mailing list
> >>> > webkit-dev at lists.webkit.org
> >>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >>> >
> >>> >
> >>> _______________________________________________
> >>> webkit-dev mailing list
> >>> webkit-dev at lists.webkit.org
> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >>
> >>
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110608/680d91e9/attachment.html>