[webkit-dev] Timing updates for SVG SMIL animations

Darin Fisher darin at chromium.org
Wed Jul 27 14:03:08 PDT 2011


Perhaps related to this thread, shouldn't we be basing SVG animations off of
the same animation scheduler that drives requestAnimationFrame and soon CSS
animations (https://bugs.webkit.org/show_bug.cgi?id=64591)?  It seems less
than ideal to use a Timer.

-Darin


On Wed, Jul 27, 2011 at 11:14 AM, Scott Graham <scottmg at chromium.org> wrote:

> Hi,
>
> When the Timer is fired for SMILTimeContainer to update animations, the
> elapsed time is calculated based on the client's currentTime().
>
> That elapsed time is passed into updateAnimations and is used most of the
> way "down".
>
> In some cases during the update though, SMILTimeContainer::elapsed() is
> re-called (e.g. in SVGSMILElement::beginListChanged, endListChanged,
> createInstanceTimesFromSyncbase).
>
> This seems somewhat incorrect because it means that various parts of the
> animation will be updated with (slightly) different elapsed times than
> others. It also makes it impractical to use a debugger to step the code.
>
> Does anyone disagree that all updates should use the same elapsed time
> during the update? Or, in other words, is there any reason to re-get the
> current wallclock time during the update?
>
> Thanks,
> Scott
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110727/a3c3c597/attachment.html>


More information about the webkit-dev mailing list