[webkit-dev] Timing updates for SVG SMIL animations

[Simon Fraser]

On Jul 27, 2011, at 11:14 AM, Scott Graham wrote:

> Hi,
> 
> When the Timer is fired for SMILTimeContainer to update animations, the elapsed time is calculated based on the client's currentTime().
> 
> That elapsed time is passed into updateAnimations and is used most of the way "down".
> 
> In some cases during the update though, SMILTimeContainer::elapsed() is re-called (e.g. in SVGSMILElement::beginListChanged, endListChanged, createInstanceTimesFromSyncbase).
> 
> This seems somewhat incorrect because it means that various parts of the animation will be updated with (slightly) different elapsed times than others. It also makes it impractical to use a debugger to step the code.
> 
> Does anyone disagree that all updates should use the same elapsed time during the update? Or, in other words, is there any reason to re-get the current wallclock time during the update?

I think your analysis is correct. You should file a bug for this in bugs.webkit.org, and folks can review your proposed changes there.

Simon