[webkit-dev] LayoutTests results fallback graph

Adam Barth abarth at webkit.org
Sun Jul 10 13:20:57 PDT 2011

On Sun, Jul 10, 2011 at 1:07 PM, Mark Rowe <mrowe at apple.com> wrote:
> On 2011-07-10, at 12:46, Adam Barth wrote:
>> On Sun, Jul 10, 2011 at 12:38 PM, Mark Rowe <mrowe at apple.com> wrote:
>>> On 2011-07-10, at 10:52, Adam Barth wrote:
>>>> Hi webkit-dev,
>>>> In trying to understand how our LayoutTest results system works, I've
>>>> created a digram of the fallback graph among the various
>>>> platform-specific directories:
>>>> https://docs.google.com/drawings/d/1z65SKkWrD4Slm6jobIphHwwRADyUtjOAxwGBVKBY8Kc/edit?hl=en_US
>>>> Unfortunately, the fallback graph is not a tree, as one might imagine
>>>> initially.  I'd like to propose two small changes, which will
>>>> hopefully make the system more sensible globally.  I'm happy to do all
>>>> the work required to make these changes:
>>>> 1) The "win" port should fall back either to "all" (the platform
>>>> independent results) or to "mac," but not to "mac-snowleopard", as it
>>>> does currently.  (I slightly prefer "all", but "mac" would also be
>>>> fine with me.)
>>> I'd argue that falling back to "mac" doesn't make any sense.  The regression tests are run against a WebKit using the latest shipping Safari's version of the underlying dependencies.  That almost always corresponds to the latest shipping Mac OS X release's components, and not to the components from future versions of Mac OS X.
>> There appears to be almost zero practical different between "win"
>> falling back to "mac" versus falling back to "mac-snowleopard":
>> abarth at quadzen:~/git/webkit/LayoutTests/platform$ find mac -name "*.png" | wc -l
>>    6688
>> abarth at quadzen:~/git/webkit/LayoutTests/platform$ find
>> mac-snowleopard/ -name "*.png" | wc -l
>>       3
> I'm not sure what that is meant to convey.  What you're proposing is changing the fallback path for the Windows port from one that is conceptually correct with one that is incorrect.  Neither your emails so far nor the diagram in your initial message have provided any explanation as to why this is.  Perhaps you'd like to expand on what purpose this proposed change has and what benefits it would provide.

Sure.  I'll highlight the relevant section of my original email:

On Sun, Jul 10, 2011 at 10:52 AM, Adam Barth <abarth at webkit.org> wrote:
> These changes have the following virtues:
> A) The resulting fallback graph will be a tree, making the fallback
> graph easier to understand for both humans and automated tools.


More information about the webkit-dev mailing list