[webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

Maciej Stachowiak mjs at apple.com
Wed Jul 6 03:19:30 PDT 2011


On Jul 5, 2011, at 4:51 PM, Dirk Pranke wrote:

> 
> On Tue, Jul 5, 2011 at 3:46 PM, Ojan Vafai <ojan at chromium.org> wrote:
>> We could simplify the syntax somewhat to not require the "= PASS" at the
>> end. We could also change the bug format to be actual links instead (e.g.
>> webkit.org/b/12345 and crbug.com/12345).
>> webkit.org/b/12345 : fast/canvas/canvastest.html
>> You can also list multiple bug per line:
>> webkit.org/b/12345 webkit.org/b/33333 : fast/canvas/canvasttest.html
>> That seem OK?

I like the idea of using links for bugs. Then it's easy to look it up without having to manually translate it. You could even go nuts and include the http://.


> 
> I'm not so much a fan of this change. It's more typing and I'm not
> sure if it makes anything much easier for the user (maybe viewing in a
> text editor that will automatically hyperlink the text, I guess).

Using a bug URL should in theory require no typing, you just cut and paste it. Unfortunately the default display URL for bugs is longer than the format above (https://bugs.webkit.org/show_bug.cgi?id=12345 instead of http://webkit.org/b/12345) but I am sure we could fix that if we cared to.

And yes, it's easier on the reader, because you can just cut & paste the bug URL instead of having to convert BUGWK12345 into something usable, even if not using a text editor that highlights links. And you can paste it into IRC or an email and it is usable to your reader, again without having to translate.

Regards,
Maciej



More information about the webkit-dev mailing list