[webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?
rniwa at webkit.org
Tue Jul 5 15:43:54 PDT 2011
On Tue, Jul 5, 2011 at 3:22 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> That's right, layout tests were designed to be regression tests rather than
> correctness tests. They are supposed to detect changes in behavior. Having
> an existing bug is not necessarily a good reason to drop test coverage.
> I think instead of introducing a new -failing.txt concept, a better
> approach would be to have a way to mark in test_expectations.txt that the
> checked-in -expected.txt for that particular platform represents a bug. I
> think that is a better way to indicate the state, all in a centralized
> place, than using a different filename.
We can already do this by adding a line:
BUG????? my-test.html = PASS
as I wrote earlier. This will force DRT to still run the test and compare
the result with the existing my-test-expected.txt and my-test-expected.png
if there is one.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev