[webkit-dev] proposal: pass --exit-after-n-failures 500 to old-run-webkit-tests on the bots

Eric Seidel eric at webkit.org
Thu Jan 13 14:11:26 PST 2011


I mean, we could also have it always stop after 5 crashes, but default
to 500 for failures or something.  Failures (with the exception of
timeouts) don't really take that much time.

-eric

On Thu, Jan 13, 2011 at 1:51 PM, Ojan Vafai <ojan at chromium.org> wrote:
> There are legit changes that cause hundreds of tests to fail due to needing
> new baselines (e.g. any skia change), so 500 seems about right to me.
>
> On Thu, Jan 13, 2011 at 1:38 PM, Eric Seidel <eric at webkit.org> wrote:
>>
>> I would opt for a lower limit, but 500 is certainly better than no limit.
>> :)
>>
>> I would certainly r+ any such change you were to send my way!
>>
>> -eric
>>
>> On Thu, Jan 13, 2011 at 9:38 AM, Ojan Vafai <ojan at chromium.org> wrote:
>> > Seems reasonable.
>> >
>> > On Thu, Jan 13, 2011 at 8:18 AM, Osztrogonac Csaba
>> > <oszi at inf.u-szeged.hu>
>> > wrote:
>> >>
>> >> Hi WebKit developers,
>> >>
>> >> Yesterday http://trac.webkit.org/changeset/75682 made all layout tests
>> >> fail
>> >> and buildbots sick, because of an accidentally committed debug puts().
>> >> The
>> >> size of results for ~22000 failing layout tests is more than 100Mb.
>> >> This
>> >> very big filesize is absolutely unnecessary, storage and network
>> >> killer.
>> >>
>> >> I propose to pass --exit-after-n-failures 500 option to the
>> >> old-run-webkit-tests
>> >> on the buildbots to make buildbot master and slaves happier. 500 should
>> >> be
>> >> more
>> >> than enough for online rebaselining and avoid 100Mb sized result files.
>> >> I filed a bug for it: https://bugs.webkit.org/show_bug.cgi?id=52364
>> >>
>> >> Any objections or seconder for this change?
>> >>
>> >> br,
>> >> Ossy
>> >>
>> >> _______________________________________________
>> >> webkit-dev mailing list
>> >> webkit-dev at lists.webkit.org
>> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> >
>> >
>> > _______________________________________________
>> > webkit-dev mailing list
>> > webkit-dev at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> >
>> >
>
>


More information about the webkit-dev mailing list