[webkit-dev] [Mac] Pixel test passed but the text dump differs.

Ryosuke Niwa rniwa at webkit.org
Mon Jan 10 12:10:23 PST 2011


On Mon, Jan 10, 2011 at 12:09 PM, Ryosuke Niwa <ryosuke.niwa at gmail.com>wrote:

> This might be due to my first patch for
> https://bugs.webkit.org/show_bug.cgi?id=51389
>
> Best,
> Ryosuke
>
> On Mon, Jan 10, 2011 at 11:42 AM, Darin Adler <darin at apple.com> wrote:
>
>> On Jan 10, 2011, at 11:05 AM, Jia Pu wrote:
>>
>> > I just noticed that there're a few spelling correction tests are failing
>> on TOT on mac. The pixel tests still pass, but the text dump are different.
>> More specifically, all the differences are on numeral value in the phrase
>> "#document toDOMRange:range from 1 of #text". I have attached a snippet of
>> such diff at the end of email. Is this a known change that requires
>> regenerating expected test results?
>>
>> That sounds familiar. There was a change that affected these modification
>> delegate methods, I think done by Ryosuke, and he updated results for many
>> tests. I think he probably missed these when doing that.
>>
>> I couldn’t quickly find the bug number or the revision number.
>>
>>    -- Darin
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110110/ec4ccde9/attachment.html>


More information about the webkit-dev mailing list